Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auditor certificates (PLT-5768) #74

Merged
merged 3 commits into from
Jul 26, 2023
Merged

feat: auditor certificates (PLT-5768) #74

merged 3 commits into from
Jul 26, 2023

Conversation

bogdan-manole
Copy link
Collaborator

@bogdan-manole bogdan-manole commented May 10, 2023 •
edited
Loading

  • add support for aarch64 (not tested yet)
  • decouple the Certification entity from direct relation with the Run entity (FE might have to adapt the old certification expected schema )

@bogdan-manole bogdan-manole changed the base branch from master to feat/subscriptions May 10, 2023 20:42
Base automatically changed from feat/subscriptions to master May 15, 2023 17:56
@bogdan-manole
chore: add support for aarch64-linux
cfcd6ee
@bogdan-manole
chore: generalize certification entity for multiple layers
d4e109c 
decouple the direct realation between Run and Certification entities and introduce a one-to-one L1Certification entity
@bogdan-manole bogdan-manole marked this pull request as ready for review June 20, 2023 12:11
bogdan-manole
bogdan-manole commented Jul 13, 2023
View reviewed changes
flake.nix Show resolved Hide resolved
development.anchors.txt Outdated Show resolved Hide resolved
plutus-certification.cabal Outdated Show resolved Hide resolved
src/Plutus/Certification/Metadata/Types.hs Show resolved Hide resolved
RSoulatIOHK
RSoulatIOHK approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@RSoulatIOHK RSoulatIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, just a comment on L1 issued by auditor subscriber.
We can address it later.

src/Plutus/Certification/Synchronizer.hs Show resolved Hide resolved
@bogdan-manole bogdan-manole merged commit cb0cd5c into master Jul 26, 2023
2 checks passed
@bogdan-manole bogdan-manole deleted the feat/auditor-certifications branch July 26, 2023 19:55
@amnambiar amnambiar mentioned this pull request Sep 9, 2023
Merged
@amnambiar amnambiar mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSoulatIOHK RSoulatIOHK RSoulatIOHK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdan-manole @RSoulatIOHK