Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cat-voices): account page back navigation #998

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

damian-molinski
Copy link
Contributor

Description

This PR fixes bug with back navigation from account page. When we're calling 'go' on AccountPageRoute it clears stack with only account page in it. In such case we can not just call pop.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added bug Something isn't working review me PR is ready for review dart Pull requests that update Dart code labels Oct 14, 2024
@damian-molinski damian-molinski self-assigned this Oct 14, 2024
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-molinski damian-molinski merged commit f7de3d2 into main Oct 14, 2024
38 checks passed
@damian-molinski damian-molinski deleted the fix/account_back_navigation branch October 14, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants