-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cat-gateway): config API #981
Conversation
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
Signed-off-by: bkioshn <[email protected]>
Re endpoints. Use:
GET and PUT are enough to signify if it's a read or write. PUT is more correct because we are setting the whole resource, its "idempotent". Doing the same PUT multiple times is the same as doing it once. There is no requirement for On PUT, the ip addr is a query parameter, if its specified you write the IP config record with the JSON given (if its valid) and it its not, you write the general config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for requested changes
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
catalyst-gateway/bin/src/db/event/config/jsonschema/frontend.json
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/db/event/config/jsonschema/frontend.json
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/db/event/config/jsonschema/frontend.json
Outdated
Show resolved
Hide resolved
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
catalyst-gateway/bin/src/db/event/config/jsonschema/frontend.json
Outdated
Show resolved
Hide resolved
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Implement a config API endpoint
Related Issue(s)
Closes #926
Description of Changes
Create a config endpoint
GET /api/draft/config/frontend
GET /api/draft/config/frontend/schema
PUT /api/draft/config/frontend?ip=<ipAddress>
ip
is not specify, update the general configAdditional Changes
Please confirm the following checks