Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): registration seed phrase step #897

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

damian-molinski
Copy link
Contributor

Description

  • In future we should have more gradual control of BlocBuilder , possible by having only one final class RegistrationState with step in it.
  • Remove public KeychainCreationController and WalletLinkController and make them internal for RegistrationBloc.
  • Event based communication.
  • Generic SeedPhrasePicture widget which can animate as state changes

Related Issue(s)

Part of #816

Screenshots

Screenshot 2024-09-27 at 16 04 20 Screenshot 2024-09-27 at 16 04 27
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added review me PR is ready for review ux/ui UX/UI related issues dart Pull requests that update Dart code labels Sep 27, 2024
@damian-molinski damian-molinski self-assigned this Sep 27, 2024
@damian-molinski damian-molinski marked this pull request as ready for review September 27, 2024 14:10
@damian-molinski damian-molinski requested review from dtscalac and removed request for minikin September 27, 2024 14:10
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 253/253}$ | ${\color{red}Fail: 0/253}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

1 participant