feat(cat-voices): My account, modals #894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Test Report | |
…account_822_modals # Conflicts: # catalyst_voices/packages/catalyst_voices_localization/lib/generated/catalyst_voices_localizations.dart # catalyst_voices/packages/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_en.dart # catalyst_voices/packages/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_es.dart # catalyst_voices/packages/catalyst_voices_localization/lib/l10n/intl_en.arb
digitalheartxs
added
review me
| onRemoveKeychainConfirmed: () async { | ||
| // TODO(Jakub): remove keychain | ||
| Navigator.of(context).pop(); | ||
| await VoicesDialog.show<void>( |
There was a problem hiding this comment.
Problem here is that you're using context from DeleteKeychainDialog dialog, which is going to be disposed soon. Probably its not end of the world but this is not good practice and nesting is bad :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modals in My account
Related Issue(s)
Closes #822
Screenshots
modals.mp4
Please confirm the following checks