Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): registration dialog structure #886

Merged
merged 12 commits into from
Sep 26, 2024

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Sep 25, 2024

Description

  • Initial structure for create keychain dialog
  • Introduces extracted InformationPanel which can be reused across different stages.

Related Issue(s)

Part of #816

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added review me PR is ready for review dart Pull requests that update Dart code labels Sep 25, 2024
@damian-molinski damian-molinski self-assigned this Sep 25, 2024
@damian-molinski damian-molinski removed the request for review from minikin September 25, 2024 12:54
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Test Report | ${\color{lightgreen}Pass: 260/260}$ | ${\color{red}Fail: 0/260}$ |

@damian-molinski damian-molinski marked this pull request as draft September 26, 2024 07:45
@damian-molinski damian-molinski added do not review yet Do not review yet and removed review me PR is ready for review labels Sep 26, 2024
@damian-molinski damian-molinski marked this pull request as ready for review September 26, 2024 10:34
@damian-molinski damian-molinski added review me PR is ready for review and removed do not review yet Do not review yet labels Sep 26, 2024
@damian-molinski damian-molinski changed the title feat(cat-voices): create keychain dialog structure feat(cat-voices): registration dialog structure Sep 26, 2024
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dtscalac dtscalac merged commit 4327abb into main Sep 26, 2024
30 of 32 checks passed
@dtscalac dtscalac deleted the feat/create_keychain_dialog_structure branch September 26, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants