Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cat-voices): task picture scaling #882

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

damian-molinski
Copy link
Contributor

Description

Fixes scaling problem of task TaskPicture

Related Issue(s)

Part of #816
Part of #818

Screenshots

scaling.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski self-assigned this Sep 25, 2024
@damian-molinski damian-molinski added bug Something isn't working dart Pull requests that update Dart code UI Kit Reusable UI components (widgets) labels Sep 25, 2024
@damian-molinski damian-molinski requested review from dtscalac and removed request for minikin September 25, 2024 08:27
@damian-molinski damian-molinski added the review me PR is ready for review label Sep 25, 2024
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damian-molinski damian-molinski enabled auto-merge (squash) September 25, 2024 08:35
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 258/258}$ | ${\color{red}Fail: 0/258}$ |

@damian-molinski damian-molinski merged commit e75eab9 into main Sep 25, 2024
32 checks passed
@damian-molinski damian-molinski deleted the fix/task_picture_scaling branch September 25, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dart Pull requests that update Dart code review me PR is ready for review UI Kit Reusable UI components (widgets)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants