Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dart/catalyst_cardano_serialization): fix samples in readme #880

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

dtscalac
Copy link
Contributor

Description

Fixes samples in README.md files after recent refactors.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels Sep 24, 2024
@dtscalac dtscalac self-assigned this Sep 24, 2024
@dtscalac dtscalac requested review from damian-molinski and digitalheartxs and removed request for stevenj and minikin September 24, 2024 19:30
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 258/258}$ | ${\color{red}Fail: 0/258}$ |

Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dtscalac dtscalac merged commit c1bbf1a into main Sep 25, 2024
32 checks passed
@dtscalac dtscalac deleted the fix/catalyst-cardano-serialization-sample branch September 25, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants