Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): Account popup #857

Merged
merged 15 commits into from
Sep 23, 2024
Merged

Conversation

digitalheartxs
Copy link
Contributor

Description

The account popup visible after tapping avatar

Related Issue(s)

Part of #822

Screenshots

Screenshot 2024-09-20 at 17 02 21 Screenshot 2024-09-20 at 17 03 02

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Test Report | ${\color{lightgreen}Pass: 221/221}$ | ${\color{red}Fail: 0/221}$ |

@stevenj stevenj added the review me PR is ready for review label Sep 21, 2024
@stevenj stevenj added this to the M4: Voting & Delegation milestone Sep 21, 2024
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dtscalac dtscalac enabled auto-merge (squash) September 23, 2024 11:21
@dtscalac dtscalac merged commit 24f8658 into main Sep 23, 2024
15 of 17 checks passed
@dtscalac dtscalac deleted the feat/my_account_822_account_popup branch September 23, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants