Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cat-voices): rename wallet test folder #856

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Sep 20, 2024

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #1, Resolves #1 Fixes #1

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@kukkok3 kukkok3 self-assigned this Sep 20, 2024
@kukkok3 kukkok3 added the do not merge yet PR is not ready to be merged yet label Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

Test Report | ${\color{lightgreen}Pass: 221/221}$ | ${\color{red}Fail: 0/221}$ |

dtscalac
dtscalac previously approved these changes Sep 23, 2024
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kukkok3 kukkok3 changed the title fix: rename wallet test folder fix(cat-voices): rename wallet test folder Sep 23, 2024
@kukkok3 kukkok3 merged commit 53f122c into main Sep 23, 2024
32 checks passed
@kukkok3 kukkok3 deleted the fix-rename-wallet-test-folder branch September 23, 2024 12:34
@kukkok3 kukkok3 removed the do not merge yet PR is not ready to be merged yet label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

First
2 participants