Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): Add CIP-39 seed phrase utility #852

Merged
merged 19 commits into from
Sep 23, 2024
Merged

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Sep 20, 2024

Description

Added a CIP-39 seed phrase utility including the SeedPhrase class and its unit tests.

The implementation requires to add a new linting rule implementation_imports as it needs to import the BIP-39 word list from internal of the bip39 package.

Related Issue(s)

Closes #812

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem linked an issue Sep 20, 2024 that may be closed by this pull request
3 tasks
@apskhem apskhem self-assigned this Sep 20, 2024
@apskhem apskhem added review me PR is ready for review dart Pull requests that update Dart code labels Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

Test Report | ${\color{lightgreen}Pass: 221/221}$ | ${\color{red}Fail: 0/221}$ |

catalyst_voices/lib/common/bip39/seed_phrase.dart Outdated Show resolved Hide resolved
catalyst_voices/lib/common/bip39/seed_phrase.dart Outdated Show resolved Hide resolved
catalyst_voices/lib/common/bip39/seed_phrase.dart Outdated Show resolved Hide resolved
catalyst_voices/lib/common/bip39/seed_phrase.dart Outdated Show resolved Hide resolved
catalyst_voices/pubspec.yaml Outdated Show resolved Hide resolved
catalyst_voices/test/common/bip39/seed_phrase_test.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dtscalac dtscalac enabled auto-merge (squash) September 23, 2024 09:21
@dtscalac dtscalac merged commit 177e2ee into main Sep 23, 2024
17 checks passed
@dtscalac dtscalac deleted the feat/seed-phrase-utils branch September 23, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Seed Phrase
3 participants