Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep drawer open when space changes #806

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

damian-molinski
Copy link
Contributor

@damian-molinski damian-molinski commented Sep 13, 2024

Related Tasks

Part of #726

Description

This PR change space change via Drawer. Now Drawer wont close automatically when space is changed.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added review me PR is ready for review ux/ui UX/UI related issues dart Pull requests that update Dart code labels Sep 13, 2024
@damian-molinski damian-molinski self-assigned this Sep 13, 2024
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Test Report | ${\color{lightgreen}Pass: 209/209}$ | ${\color{red}Fail: 0/209}$ |

@damian-molinski damian-molinski enabled auto-merge (squash) September 13, 2024 11:57
@damian-molinski damian-molinski requested review from dtscalac and digitalheartxs and removed request for minikin September 13, 2024 11:58
@damian-molinski damian-molinski merged commit b739298 into main Sep 13, 2024
17 of 18 checks passed
@damian-molinski damian-molinski deleted the feat/space_switch_drawer branch September 13, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants