Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add patrol poc #524

Closed
wants to merge 12 commits into from
Closed

feat: add patrol poc #524

wants to merge 12 commits into from

Conversation

SotaTek-DuyLe
Copy link
Contributor

@SotaTek-DuyLe SotaTek-DuyLe commented Jun 3, 2024

Description

Investigate the use of Patrol for flutter integration and end2end tests instead of flutter native integration tests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@SotaTek-DuyLe SotaTek-DuyLe linked an issue Jun 3, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Test Report | ${\color{lightgreen}Pass: 48/50}$ | ${\color{red}Fail: 2/50}$ |

@dtscalac
Copy link
Contributor

dtscalac commented Jun 4, 2024

@SotaTek-DuyLe Can you please update the PR description? Just leave the relevant fields, you can have a look at some closed PRs

setPathUrlStrategy();
Bloc.observer = AppBlocObserver();

// await bootstrap(() => const App());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will refactor this code on your branch because it works for patrol tests but breaks the normal app launch. Most likely we need two methods, one for normal launch, another one for tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a new file: main_qa_patrol.dart

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I refactored it to make sure it's synced with bootstrap

@dtscalac dtscalac marked this pull request as draft June 4, 2024 08:50
@dtscalac
Copy link
Contributor

dtscalac commented Jun 4, 2024

Converting to a draft, I need to refactor the initialization logic to work both for tests and normal app launches.

@dtscalac dtscalac added dart Pull requests that update Dart code do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels Jun 4, 2024
@SotaTek-DuyLe SotaTek-DuyLe marked this pull request as ready for review June 5, 2024 08:08
import 'common.dart';

void main() {
patrol('Test Landing page', (PatrolIntegrationTester $) async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a section in catalyst_voices/README.md how to run the patrol test?

@SotaTek-DuyLe
Copy link
Contributor Author

Closing due to patrol incompatibility with web testing

@dtscalac dtscalac deleted the feat/329-add-patrol-poc branch June 10, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code do not merge yet PR is not ready to be merged yet do not review yet Do not review yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Patrol POC
2 participants