-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add patrol poc #524
feat: add patrol poc #524
Conversation
❌ Test Report | |
@SotaTek-DuyLe Can you please update the PR description? Just leave the relevant fields, you can have a look at some closed PRs |
setPathUrlStrategy(); | ||
Bloc.observer = AppBlocObserver(); | ||
|
||
// await bootstrap(() => const App()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will refactor this code on your branch because it works for patrol tests but breaks the normal app launch. Most likely we need two methods, one for normal launch, another one for tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created a new file: main_qa_patrol.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I refactored it to make sure it's synced with bootstrap
Converting to a draft, I need to refactor the initialization logic to work both for tests and normal app launches. |
import 'common.dart'; | ||
|
||
void main() { | ||
patrol('Test Landing page', (PatrolIntegrationTester $) async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a section in catalyst_voices/README.md how to run the patrol test?
Closing due to patrol incompatibility with web testing |
Description
Investigate the use of Patrol for flutter integration and end2end tests instead of flutter native integration tests
Please confirm the following checks