Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cardano wallet api #522

Merged
merged 9 commits into from
Jun 4, 2024
Merged

feat: cardano wallet api #522

merged 9 commits into from
Jun 4, 2024

Conversation

dtscalac
Copy link
Contributor

Description

  • Adds initial CIP-30 API as a flutter package.

Remaining work for future PRs

  • Map all CIP-30 exceptions from JS to dart
  • Add integration tests that setup the wallet extension and communicate with the wallet
  • Implement CIP-95 extension

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels May 31, 2024
@dtscalac dtscalac self-assigned this May 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited
Loading

❌ Test Report | ${\color{lightgreen}Pass: 133/134}$ | ${\color{red}Fail: 1/134}$ |

@dtscalac dtscalac requested a review from coire1 May 31, 2024 12:53
@dtscalac dtscalac enabled auto-merge (squash) June 3, 2024 07:11
coire1
coire1 previously approved these changes Jun 4, 2024
View reviewed changes
@dtscalac
feat: cardano wallet api example (#523)
9c9d444 
* feat: add missing import

* fix: assets path

* fix: add missing dependency

* feat: add example

* fix: method name
@dtscalac dtscalac requested a review from coire1 June 4, 2024 08:41
@dtscalac dtscalac merged commit 0a11853 into main Jun 4, 2024
30 checks passed
@dtscalac dtscalac deleted the feat/cardano-wallet-api branch June 4, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coire1 coire1 coire1 approved these changes

@minikin minikin Awaiting requested review from minikin minikin is a code owner

@stevenj stevenj Awaiting requested review from stevenj

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M3: Backend and Wallet Integration Up...
Development

Successfully merging this pull request may close these issues.
2 participants
@dtscalac @coire1