feat: generate c509 certificate + `Extensions` msg fields #518

bkioshn · 2024-05-28T09:02:00Z

Description

Setup infrastructure for C509 lib and implement Extensions message field.

Related Issue(s)

Closes #573 #389

Description of Changes

Setup a C509 lib
Create encode and decode to handle the unwrapped oid (~oid) and PEN oid as mentioned in https://datatracker.ietf.org/doc/html/rfc9090
Create a table of C509 Extension Registry (See section 9.4)
Create encode and decode to handle the int according to the C509 Extension Registry
Handle the Extensions special case for encode and decode
Handle extensionValue type only for alternative name (subjectAltName and issuerAltName will only be handled for this ticket
Test cases added

Notes:

Files structure will be revisited

All the implementation is references from https://datatracker.ietf.org/doc/draft-ietf-cose-cbor-encoded-cert/09/

Please confirm the following checks

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream module

* test: Fix tests after cat-gateway update. * docs: Add `CatalystDataGatewayRepository` usage examples. * docs: Move docs from README to code comment. * test: Update `CatalystDataGatewayRepository` tests. * test: Use Fake instead of Mock. * chore: Fix Markdown errors. * chore: Explicit use of `HttpStatus` codes.

* test: Fix tests after cat-gateway update. * docs: Add `CatalystDataGatewayRepository` usage examples. * docs: Move docs from README to code comment. * test: Update `CatalystDataGatewayRepository` tests. * test: Use Fake instead of Mock. * chore: Fix Markdown errors. * chore: Explicit use of `HttpStatus` codes. * chore(deps-dev): bump vite in /utilities/wallet-tester (#397) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.1.6 to 5.1.7. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.1.7/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.1.7/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Apisit Ritreungroj <[email protected]> * feat: Get slot number by provided date-time endpoint (#387) * fix CardanoStakeAddress error handling * refactor, add sync_state_get endpoint * refactor types * refactor * add block_hash validation * wip * wip * wip * wip * add check_network fn * fix * fix schematisis test * try * wip * try * try * try * try * wip * try * try * fix * update Network * add test_utxo test * try * fix * try * fix * wip * fix * fix docket-compose.yml file * try * try * fix * try * try * try * try * wip * fix * wip * try * try * wip * try * try * revert * wip * wip * wip * fix * fix * fix * remove mithril_snapshot loader * wip * wip * wip * wip * wip * wip * wip * add stake addr bech32 encode utils function * wip * wip * update indexing of the utxo data * fix spelling * wip * wip * finish utxo test * fix deny * fix check * fix * fix * update earthly builder versions * wip * ignore test_utxo.py in CI * dont ignore tests * add date_time_to_slot_number_get endpoint * add sql queries * fix * update slot info, fix follower indexing block time issue * add previous slot info field * fix * refactor * fix sync_state_get * wip * fix check * try * fix * finish slot_info test, fix queries * fix * cleanup * wip * wip * wip * feat: RBAC Documentation Drafting (#332) * chore: wip * Update 0005-flutter-app.md * Update 0005-flutter-app.md * Update 0005-flutter-app.md * Update 0005-flutter-app.md * Update 0005-flutter-app.md * Update 0005-flutter-app.md * Update 0005-flutter-app.md * Update 0005-flutter-app.md * Update 0005-flutter-app.md * Update 0005-flutter-app.md * Update 0005-flutter-app.md * docs(docs): Use latest docs builders and fix concepts page * docs(cips): Start drafting the CIPS for milestone 2 * docs(cips): More text for RBAC metadata draft * docs(cips): WIP updates to draft cip for role registration * docs(cips): define draft specification for a ULID cbor tag * docs(cips): Further WIP edits to RBAC * docs(cips): fix ulid spec binary encoding reference * docs(cips): Add a tag to the epoch time. * docs(cips): Add CBOR tag cip for ED25519-BIP32 Keys, Derivation paths and Signatures * docs(cips): Properly define the field tags to use where known, and clean up Stake Address specification. * docs(cips): Fix nonce so its reliable without needing blockchain data * docs(cips): updates * docs(docs): Add CDDL definition for POC x509 envelope metadata * fix(vscode): update vscode extension recommendations * docs(cips): rbac x509 envelope fix * docs(cips): wip updates to high level docs * docs(cips): Add overview of cardano transaction processign and data * docs(cips): update cardano block to be complete for clarity * docs(cips): fix layout engine * docs(cips): wip cddl for envelope metadata * docs(cips): Add cddl specs and diagrams for x509 rbac registration work * docs(cips): Add full transaction/metadata relationship diagram * refactor(cips): reorganize documentation ready for drafting descriptive prose about the formats and uses * docs(cips): add cip draft for catalyst roles using the x509-rbac standard * docs(cips): Add c509 cddl with restrictions and enhancements for plutus usage * docs(cips): Metadata envelope specification draft complete * Update docs/src/catalyst-standards/draft-cips/c509-plutus-restricted-certificate/c509-cert-plutus-restricted.cddl Co-authored-by: bkioshn <[email protected]> * Update docs/src/catalyst-standards/draft-cips/c509-plutus-restricted-certificate/c509-cert-plutus-restricted.cddl Co-authored-by: bkioshn <[email protected]> * Update docs/src/catalyst-standards/draft-cips/x509-role-registration-metadata/x509-roles.cddl Co-authored-by: bkioshn <[email protected]> * Update docs/src/catalyst-standards/draft-cips/x509-role-registration-metadata/x509-roles.cddl Co-authored-by: bkioshn <[email protected]> * Update docs/src/catalyst-standards/draft-cips/x509-envelope-metadata/x509-envelope.cddl Co-authored-by: bkioshn <[email protected]> * Update docs/src/catalyst-standards/draft-cips/x509-envelope-metadata/x509-envelope.cddl Co-authored-by: bkioshn <[email protected]> * Update docs/src/catalyst-standards/draft-cips/x509-envelope-metadata/x509-envelope.cddl Co-authored-by: bkioshn <[email protected]> * Update docs/src/catalyst-standards/draft-cips/c509-plutus-restricted-certificate/c509-cert-plutus-restricted.cddl Co-authored-by: bkioshn <[email protected]> * docs(cips): Fix time and algorithm comments * build(frontend): Relax flutter/dart version requirements to last minor release * docs(cips): wip * fix(cips): rename draft x509 envelope CIP so its easier to identify * docs(cips): WIP updates to x509 roles * fix(cips): rename RBAC definition CIP draft so its easier to identify * docs(cips): x509 certificate registration format fully defined * docs(cips): Document the restricted plutus subset. * docs(cips): Add document detailing how CIP-30 is used to sign the transaction * fix(cips): remove trailing spaces * fix(cips): Fix line lengths * fix(cips): Correct spelling * fix(cips): spelling * fix(frontend): revert changes to flutter/dart versions * fix(frontend): more flutter/dart version corrections * fix(frontend): Revert flutter files to same as main branch * fix(frontend): revert more flutter .yml files to those in main * fix(cips): Fix links between files * docs(cips): Add catalyst specific role registration documentation * docs(spelling): fix spelling --------- Co-authored-by: minikin <[email protected]> Co-authored-by: bkioshn <[email protected]> * ci: configure static analysis & code formatting check * style: formatting * fix: revert browser installation scripts * style: format code * ci: optimize directions include in repo-catalyst-voices-all artifact to include only needed ones * refactor: remove empty tests * ci: add melos script to generate test reports * ci: melos script to generate test report * style: revert previously generated files formatting * style: format files * ci: update melos to exclude generated code form code coverage * ci: cleanup build script * ci: generate multiple junit test reports and save them at /test_reports * ci: depend on melos analyze instead of custom command * docs: improve melos docs * ci: remove unused melos scripts * ci: format files in test & integration_test directories * ci: break code to make sure CI will report failure for demonstration purposes * style: fix lint issues * ci: change WORKDIR after creating the user to make sure it will be owned by that user * ci: restore root user * Revert "Merge branch 'main' into feat/collect-flutter-code-coverage" This reverts commit d0f66b2, reversing changes made to 39ce401. * style: format code * ci: revert test-unit target name --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Lucio Baglione <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Apisit Ritreungroj <[email protected]> Co-authored-by: Alex Pozhylenkov <[email protected]> Co-authored-by: Steven Johnson <[email protected]> Co-authored-by: minikin <[email protected]> Co-authored-by: bkioshn <[email protected]>

* update schema_validation check * wip * fix

catalyst-gateway-crates/c509-certificate/src/c509_general_names/general_name.rs

Mr-Leshiy

LGTM

Done

Changes Done

stevenj

LGTM

catalyst-gateway-crates/c509-certificate/src/c509_general_names/data.rs

stevenj

LGTM

bkioshn and others added 30 commits April 8, 2024 19:29

feat: setup c509 lib

76d78b2

fix: update toml file

ef76f02

feat: add earthfile

19db45e

Merge branch 'main' into feat/setup-c509-lib

bc5b859

fix: remove blank line

083c8e7

Merge branch 'feat/m3' into feat/setup-c509-lib

a25c041

adds one more worker and compression for catgateway logs (#400)

805482c

Merge branch 'main' into feat/m3

0f8916e

refactor: update schema_validation check (#414)

6365ce9

* update schema_validation check * wip * fix

Merge branch 'feat/m3' into feat/setup-c509-lib

aaf6809

fix: update wasm testing

8ebd6ce

fix: remove clippy toml

1388eff

Merge branch 'main' into feat/setup-c509-lib

84ae2c7

fix: update cargo toml

4226d49

fix: spelling

0106768

fix: revert test report

3c89375

chore: add comment

a0ac9ab

chore: update message

9ad1978

fix: update cargo.toml

06ae7c5

chore: fix format

0c61614

fix: linter

8c045f9

fix: update cargo toml

51e5b6e

fix: update cargo toml

6eb77b0

Merge branch 'main' into feat/setup-c509-lib

68e8566

fix: update project dic

64622fc

fix: remove wasm-pack install

842d5d9

feat: add config

672166a

fix: earthly for c509

70485dc

bkioshn added 5 commits July 8, 2024 09:59

fix: move code section

7817f8c

chore: fix name and comment

45d14ee

fix: format

ab586ee

test: add zero extensions

b405496

fix: format

b8b2a2a

Mr-Leshiy requested changes Jul 8, 2024

View reviewed changes

catalyst-gateway-crates/c509-certificate/src/c509_general_names/general_name.rs Outdated Show resolved Hide resolved

fix: gn type naming

9409cf2

bkioshn requested review from Mr-Leshiy and apskhem July 9, 2024 02:04

Mr-Leshiy previously approved these changes Jul 9, 2024

View reviewed changes

bkioshn added 5 commits July 9, 2024 15:39

chore: remove unused file

0b3296d

test: add test case for multiples gn type

2b069b2

fix: dns gn decode special case

a8ff97d

fix: format

bae088a

fix: data tables

db23d96

bkioshn dismissed Mr-Leshiy’s stale review via db23d96 July 9, 2024 09:10

bkioshn added 2 commits July 9, 2024 16:22

fix: alt name test case

6492464

fix: cspell

325430a

stevenj self-requested a review July 9, 2024 13:37

stevenj removed the do not merge yet PR is not ready to be merged yet label Jul 9, 2024

stevenj previously approved these changes Jul 9, 2024

View reviewed changes

catalyst-gateway-crates/c509-certificate/src/c509_general_names/data.rs Outdated Show resolved Hide resolved

fix: table functions

06130fc

bkioshn dismissed stevenj’s stale review via 06130fc July 10, 2024 02:31

bkioshn added 2 commits July 10, 2024 09:48

fix: format

800688a

chore: fix test comment

1107588

stevenj approved these changes Jul 10, 2024

View reviewed changes

stevenj merged commit 35f8325 into main Jul 10, 2024
29 checks passed

stevenj deleted the feat/c509-cert branch July 10, 2024 11:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: generate c509 certificate + `Extensions` msg fields #518

feat: generate c509 certificate + `Extensions` msg fields #518

bkioshn commented May 28, 2024 •

edited

Loading

Mr-Leshiy left a comment

stevenj left a comment

stevenj left a comment

feat: generate c509 certificate + Extensions msg fields #518

feat: generate c509 certificate + Extensions msg fields #518

Conversation

bkioshn commented May 28, 2024 • edited Loading

Description

Related Issue(s)

Description of Changes

Notes:

Please confirm the following checks

Mr-Leshiy left a comment

Choose a reason for hiding this comment

stevenj left a comment

Choose a reason for hiding this comment

stevenj left a comment

Choose a reason for hiding this comment

feat: generate c509 certificate + `Extensions` msg fields #518

feat: generate c509 certificate + `Extensions` msg fields #518

bkioshn commented May 28, 2024 •

edited

Loading