Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add brand specific assets #517

Merged
merged 6 commits into from
May 29, 2024
Merged

Conversation

coire1
Copy link
Contributor

@coire1 coire1 commented May 27, 2024

Description

This PR introduces the ThemeExtension BrandAssets that allows to have assets that are specific for brand.
A specific use case for that is related to logos: in this way when a brand is switched and the related Theme is loaded also the logo can be updated accordingly. This approach can be used for every brand specific asset in the application.

Related Issue(s)

Closes #497

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@coire1 coire1 requested a review from dtscalac May 27, 2024 13:46
@coire1 coire1 self-assigned this May 27, 2024
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 97/99}$ | ${\color{red}Fail: 2/99}$ |

@coire1 coire1 marked this pull request as ready for review May 29, 2024 09:58
@coire1 coire1 requested a review from minikin as a code owner May 29, 2024 09:58
@coire1 coire1 enabled auto-merge (squash) May 29, 2024 09:59
@coire1 coire1 added the review me PR is ready for review label May 29, 2024
@coire1 coire1 merged commit 09737e3 into main May 29, 2024
32 checks passed
@coire1 coire1 deleted the feat/add-brand-specific-assets branch May 29, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Extend brands to support brand logo
2 participants