Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cardano wallet cip 30 #516

Closed
wants to merge 17 commits into from
Closed

feat: cardano wallet cip 30 #516

wants to merge 17 commits into from

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented May 27, 2024 •
edited
Loading

Description

Remaining work for future PRs

  • Map all CIP-30 exceptions from JS to dart
  • Add integration tests that setup the wallet extension and communicate with the wallet
  • Implement signData (not needed for now)
  • Implement CIP-95 extension

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac
feat: POC for cardano mulitplatform lib js_interop from dart
f56da9b
@dtscalac
fix: remove unwanted method invocation
7b6dddb
@dtscalac
fix: unused import
a0a1d46
@dtscalac
fix: README formatting
4e58eee
@dtscalac
fix: make sure exception is not silenced
2fbd939
@dtscalac
style: blank lines
0f324b4
@dtscalac
style: too long line
0cfd4b5
@dtscalac
chore: ignore cardano_multiplatform_lib from cspell check
0a6361e
@dtscalac
style: spelling
0d7b0cc
@dtscalac
fix: typo
8920306
@dtscalac
Merge branch 'main' into feat/poc_for_js_interop_with_cardano_mulitpl…
2bbb541 
…atform_lib

# Conflicts:
#	.config/dictionaries/project.dic
#	catalyst_voices/pubspec.yaml
@dtscalac
fix: parse any shelley address
ab700f5
@dtscalac
feat: imports and dependencies
c316293
@dtscalac
Merge branch 'feat/upgrade-flutter-to-3_22_1' into feat/poc_for_js_in…
79e9432 
…terop_with_cardano_mulitplatform_lib
@dtscalac
Merge branch 'feat/upgrade-flutter-to-3_22_1' into feat/poc_for_js_in…
f348f6c 
…terop_with_cardano_mulitplatform_lib
@dtscalac
docs: document package version
0c2b118
@dtscalac
feat: add cardano wallet api
05dc691
@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels May 27, 2024
@dtscalac dtscalac self-assigned this May 27, 2024
@dtscalac dtscalac changed the base branch from main to feat/upgrade-flutter-to-3_22_1 May 27, 2024 08:33
@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 94/96}$ | ${\color{red}Fail: 2/96}$ |

@dtscalac dtscalac closed this May 31, 2024
@dtscalac dtscalac deleted the feat/cardano-wallet-cip-30 branch May 31, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minikin minikin Awaiting requested review from minikin

@stevenj stevenj Awaiting requested review from stevenj

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M3: Backend and Wallet Integration Up...
Development

Successfully merging this pull request may close these issues.
1 participant
@dtscalac