Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change pallas dep to the catalyst-pallas fork's catalyst branch specific commit #470

Merged
merged 2 commits into from
May 7, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

Description

Changed pallas dep to the catalyst-pallas fork's catalyst branch specific commit.
catalyst branch would our upstream branch with all our updates which are not merged to the pallas main branch yet.
Also specified a commit instead of branch to make a more reliable and robust build, so any changes inside catalyst branch will not affect to the hermes without explicit updating of the this dependency.

Part of input-output-hk/hermes#229

@Mr-Leshiy Mr-Leshiy self-assigned this May 7, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label May 7, 2024
@Mr-Leshiy Mr-Leshiy changed the title feat: Change pallas dep to the catalyst-pallas fork's catalyst branch specific commit feat: Change pallas dep to the catalyst-pallas fork's catalyst branch specific commit May 7, 2024
@minikin minikin enabled auto-merge (squash) May 7, 2024 13:06
minikin
minikin previously approved these changes May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

Test Report | ${\color{lightgreen}Pass: 48/48}$ | ${\color{red}Fail: 0/48}$ |

Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit eca2847 into main May 7, 2024
22 checks passed
@minikin minikin deleted the feat/pallas-version branch May 7, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants