Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cat-voices): Removing code generated files from repo #1191

Merged
merged 21 commits into from
Nov 14, 2024

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Nov 12, 2024

Description

Removes all generated files from catalyst-voices dir except files from public packages located in /packages/libs/

Related Issue(s)

Resolves #157

Description of Changes

  • Adding files to gitignore
  • Changing earthly targets
  • Adding a section for code generation in README file

Related Pull Requests

#1187

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added do not review yet Do not review yet dart Pull requests that update Dart code labels Nov 12, 2024
@LynxLynxx LynxLynxx self-assigned this Nov 12, 2024
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/288}$ | ${\color{red}Fail: 16/288}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/288}$ | ${\color{red}Fail: 16/288}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/288}$ | ${\color{red}Fail: 16/288}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/288}$ | ${\color{red}Fail: 16/288}$ |

…ncies and adding current working directory management
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 307/310}$ | ${\color{red}Fail: 3/310}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 307/310}$ | ${\color{red}Fail: 3/310}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@LynxLynxx LynxLynxx added review me PR is ready for review and removed do not review yet Do not review yet labels Nov 13, 2024
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@minikin
Copy link
Collaborator

minikin commented Nov 13, 2024

Is this one dependent on #1187?

Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please update https://github.com/input-output-hk/catalyst-voices/blob/main/catalyst_voices/README.md and add a new section about code generation, including what we use it for, how to use it, etc.?

…tions and restructured build process for clarity
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

catalyst_voices/README.md Outdated Show resolved Hide resolved
catalyst_voices/Earthfile Outdated Show resolved Hide resolved
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 29/29}$ | ${\color{red}Fail: 0/29}$ |

@dtscalac dtscalac self-requested a review November 14, 2024 11:29
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit e91135f into main Nov 14, 2024
36 of 37 checks passed
@minikin minikin deleted the chore/157_remove_generated_files branch November 14, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Move Dart code generation to CI/CD
4 participants