-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cat-gateway): Fix native asset indexing to be more flexible #1150
base: main
Are you sure you want to change the base?
Conversation
✅ Test Report | |
✅ Test Report | |
✅ Test Report | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, these need to be corrected and then I will conduct another review.
catalyst-gateway/bin/src/db/index/schema/cql/txo_assets_by_stake_table.cql
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/db/index/schema/cql/txo_assets_by_stake_table.cql
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/db/index/schema/cql/unstaked_txo_assets_by_txn_hash.cql
Outdated
Show resolved
Hide resolved
✅ Test Report | |
✅ Test Report | |
✅ Test Report | |
✅ Test Report | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the original issue it is also telling to the change the asset value type to i128, which I dont see in this PR.
Is it really needed, or its something we dont want to do ?
amount: num_bigint::BigInt::ZERO, | ||
}); | ||
entry.amount += row.value; | ||
.or_insert_with(Vec::new); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite get it this change.
Could you elaborate what we are doing here actually ?
Description
Related Issue(s)
Closes #1121
Please confirm the following checks