Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): add result builder with delayed loading #1021

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

dtscalac
Copy link
Contributor

Description

Adds a result builder that understands different result states and can delay showing the next state to avoid showing a loader for a split-second.

Screenshots

Screen.Recording.2024-10-17.at.12.11.42.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added ux/ui UX/UI related issues dart Pull requests that update Dart code labels Oct 17, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Oct 17, 2024
@dtscalac dtscalac self-assigned this Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Test Report | ${\color{lightgreen}Pass: 294/294}$ | ${\color{red}Fail: 0/294}$ |

@dtscalac dtscalac added the review me PR is ready for review label Oct 17, 2024
@dtscalac dtscalac removed the request for review from minikin October 17, 2024 10:46
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtscalac dtscalac merged commit a330c53 into main Oct 17, 2024
34 checks passed
@dtscalac dtscalac deleted the feat/result-builder-with-delayed-loading branch October 17, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants