Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): lock/unlock keychain #1003

Merged
merged 19 commits into from
Oct 16, 2024
Merged

feat(cat-voices): lock/unlock keychain #1003

merged 19 commits into from
Oct 16, 2024

Conversation

dtscalac
Copy link
Contributor

Description

Adds support for locking / unlocking the keychain (session).

Related Issue(s)

Closes #819

Screenshots

Screenshot 2024-10-15 at Screenshot 2024-10-15 at 14 43 14 14 43 02
Screenshot 2024-10-15 at 14 43 07
Screenshot 2024-10-15 at 14 43 19
Screenshot 2024-10-15 at 14 40 11
Screenshot 2024-10-15 at 14 40 19

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac
refactor: cleanup
2c98d28
@dtscalac
feat: update snackbar to support custom messages
8cb7421
@dtscalac
feat: show localized snackbar errors
05da1bc
@dtscalac
feat: keychain unlock
fe79d5d
@dtscalac
Merge branch 'main' into feat/lock-unlock-keychain
8c7734d 
# Conflicts:
#	catalyst_voices/lib/pages/account/account_page.dart
#	catalyst_voices/packages/catalyst_voices_localization/lib/generated/catalyst_voices_localizations.dart
#	catalyst_voices/packages/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_en.dart
#	catalyst_voices/packages/catalyst_voices_localization/lib/generated/catalyst_voices_localizations_es.dart
#	catalyst_voices/packages/catalyst_voices_localization/lib/l10n/intl_en.arb
@dtscalac
refactor: error handler
4aa416f
@dtscalac
Merge branch 'main' into feat/lock-unlock-keychain
812875f 
# Conflicts:
#	catalyst_voices/lib/widgets/app_bar/session/session_state_header.dart
#	catalyst_voices/packages/catalyst_voices_blocs/lib/src/session/session_bloc.dart
@dtscalac
feat: add snackbars when locking / unlocking
1605aef
@dtscalac
feat: add custom icon to snackbar
b5eee55
@dtscalac
feat: add icons to snackbars
3656ac8
@dtscalac
fix: ui fixes
0d9d743
@dtscalac
chore: cleanup
3f18fc5
@dtscalac dtscalac added review me PR is ready for review ux/ui UX/UI related issues dart Pull requests that update Dart code labels Oct 15, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Oct 15, 2024
@dtscalac dtscalac self-assigned this Oct 15, 2024
@dtscalac dtscalac removed the request for review from minikin October 15, 2024 12:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

digitalheartxs
digitalheartxs previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@digitalheartxs digitalheartxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

damian-molinski
damian-molinski approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtscalac dtscalac merged commit cc7a8b4 into main Oct 16, 2024
35 of 37 checks passed
@dtscalac dtscalac deleted the feat/lock-unlock-keychain branch October 16, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@digitalheartxs digitalheartxs Awaiting requested review from digitalheartxs

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Catalyst
Archived in project
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Lock / Unlock
3 participants
@dtscalac @damian-molinski @digitalheartxs