store raw metadata only if cip36 data is present

input-output-hk · May 13, 2024 · eedb91e · eedb91e
1 parent 9e0783a
commit eedb91e
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/catalyst-gateway/bin/src/cardano/cip36_registration/mod.rs b/catalyst-gateway/bin/src/cardano/cip36_registration/mod.rs
@@ -100,7 +100,6 @@ pub(crate) struct Cip36Metadata {
 impl Cip36Metadata {
     /// Create new `Cip36Registration` from tx metadata
     /// Collect secondary errors for granular json error report
-    #[allow(clippy::too_many_lines)]
     pub(crate) fn generate_from_tx_metadata(
         tx_metadata: &MultiEraMeta, network: Network,
     ) -> Option<Self> {
@@ -120,14 +119,6 @@ impl Cip36Metadata {
             /// <https://cips.cardano.org/cips/cip36>
             const CIP36_WITNESS_CBOR_KEY: u64 = 61285;
 
-            raw_metadata = tx_metadata.encode_fragment().map_or_else(
-                |err| {
-                    errors_report.push(format!("cannot encode tx metadata into bytes {err}"));
-                    None
-                },
-                Some,
-            );
-
             for (key, metadata) in tx_metadata.iter() {
                 match *key {
                     CIP36_REGISTRATION_CBOR_KEY => {
@@ -160,6 +151,16 @@ impl Cip36Metadata {
                     _ => continue,
                 };
             }
+
+            if signature.is_some() || registration.is_some() {
+                raw_metadata = tx_metadata.encode_fragment().map_or_else(
+                    |err| {
+                        errors_report.push(format!("cannot encode tx metadata into bytes {err}"));
+                        None
+                    },
+                    Some,
+                );
+            }
         };
 
         if let Some(raw_61284) = raw_61284 {