refactor: test array

input-output-hk · Sep 22, 2024 · 58f630f · 58f630f
1 parent 2905984
commit 58f630f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 22 deletions.
diff --git a/catalyst_voices/packages/catalyst_voices_models/lib/src/seed_phrase.dart b/catalyst_voices/packages/catalyst_voices_models/lib/src/seed_phrase.dart
@@ -25,7 +25,7 @@ class SeedPhrase {
   SeedPhrase({int wordCount = 12})
       : this.fromMnemonic(
           bip39.generateMnemonic(
-            strength: _calculateEntropyBits(wordCount),
+            strength: (wordCount * 32) ~/ 3,
           ),
         );
 
@@ -67,11 +67,3 @@ class SeedPhrase {
   /// The full list of BIP-39 mnemonic words in English.
   static List<String> get wordList => WORDLIST;
 }
-
-int _calculateEntropyBits(int wordCount) {
-  if (wordCount <= 0 || wordCount % 3 != 0) {
-    throw ArgumentError('Word count must be divisible by 3 and greater than 0');
-  }
-
-  return (wordCount * 32) ~/ 3;
-}
diff --git a/catalyst_voices/packages/catalyst_voices_models/test/seed_phrase_test.dart b/catalyst_voices/packages/catalyst_voices_models/test/seed_phrase_test.dart
@@ -12,23 +12,17 @@ void main() {
       expect(seedPhrase.mnemonicWords.length, 12);
     });
 
-    test('should generate a seed phrase with 12 words', () {
-      final seedPhrase = SeedPhrase(wordCount: 12);
-
-      expect(seedPhrase.mnemonicWords.length, 12);
-      expect(bip39.validateMnemonic(seedPhrase.mnemonic), isTrue);
-    });
-
-    test('should generate a seed phrase with 24 words', () {
-      final seedPhrase = SeedPhrase(wordCount: 24);
-
-      expect(seedPhrase.mnemonicWords.length, 24);
-      expect(bip39.validateMnemonic(seedPhrase.mnemonic), isTrue);
+    test('should generate a seed phrase with 12, 15, 18, 21, and 24 words', () {
+      for (final wordCount in [12, 15, 18, 21, 24]) {
+        final seedPhrase = SeedPhrase(wordCount: wordCount);
+        expect(seedPhrase.mnemonicWords.length, wordCount);
+        expect(bip39.validateMnemonic(seedPhrase.mnemonic), isTrue);
+      }
     });
 
     test('should throw an error for an invalid word count', () {
       expect(() => SeedPhrase(wordCount: 9), throwsA(isA<ArgumentError>()));
-      expect(() => SeedPhrase(wordCount: 13), throwsA(isA<ArgumentError>()));
+      expect(() => SeedPhrase(wordCount: 13), throwsA(isA<AssertionError>()));
       expect(() => SeedPhrase(wordCount: 27), throwsA(isA<ArgumentError>()));
     });