Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update stage data params for f11 | NPG-000 #660

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

saibatizoku
Copy link
Contributor

Description

Updates stage_data F11 params.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
    expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saibatizoku saibatizoku added the review me PR is ready for review label Jan 22, 2024
@saibatizoku saibatizoku added this to the F11-Launch milestone Jan 22, 2024
@saibatizoku saibatizoku self-assigned this Jan 22, 2024
@saibatizoku
Copy link
Contributor Author

@coire1 @kukkok3 I've modified the EvenDB config for prod and dev stage data to use f11 params.

Could you please take a look to see if anything stands out?

Also, I didn't update the group_id, review_stage_ids, campaign_group_id, or stage_ids before asking you for proper values.

@saibatizoku saibatizoku changed the title update stage data params for f11 feat: Update stage data params for f11 - NPG-000 Jan 22, 2024
@saibatizoku saibatizoku changed the title feat: Update stage data params for f11 - NPG-000 feat: Update stage data params for f11 | NPG-000 Jan 23, 2024
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku merged commit f9cce5c into main Jan 23, 2024
59 of 63 checks passed
@saibatizoku saibatizoku deleted the feature/update-stage-data-params branch January 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants