feat: Fragment generator | NPG-0000 #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reference implementation for generating fragment in bytes format
reference implementation for generating fragment in bytes format
reference implementation for generating fragment in bytes format
cong-or
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fragment generator in byte format. As per specification.
The original idea was to isolate and rewrite a bare bones version of the specification from scratch to verify the spec and our existing implementation. This was largely done except for the cryptography. The encrypted vote part is manageable to rewrite and somewhat standard.
However the ZKP proof is not, the algorithm from the treasury paper is NOVEL and difficult to recreate with external off the shelf libs. An isolated ZKP implementation with no baggage in the context of cat-core requires a rewrite from scratch as there is no existing libs suitable; any rewrite is basically a mirror of our existing cryptography and vote crates in cat-core.
In any case, we need to use the binary of this crate within the context of our load tester. We can potentially come back to alternatives implementation of the ZKP stuff in the future.