Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Import f10 vitss | NPG-000 #588

Merged
merged 34 commits into from
Oct 5, 2023
Merged

feat: Import f10 vitss | NPG-000 #588

merged 34 commits into from
Oct 5, 2023

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Oct 2, 2023

Description

Importing vitss from https://github.com/input-output-hk/vit-servicing-station/tree/catalyst-fund9 into the monorepo. Fixed all the dependencies to be local to the monorepo. Also deleted the vitss snapshot endpoint. The depencencies of the crates in cat-core have not been changed yet from vitss to the new vitss-f10, this will be done in a following PR

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kukkok3 kukkok3 self-assigned this Oct 2, 2023
@kukkok3 kukkok3 changed the title feat : Switch to f10 vitss | NPG-000 feat : Import f10 vitss | NPG-000 Oct 2, 2023
@kukkok3 kukkok3 changed the title feat : Import f10 vitss | NPG-000 feat: Import f10 vitss | NPG-000 Oct 2, 2023
@minikin minikin added the draft Draft label Oct 4, 2023
@kukkok3 kukkok3 marked this pull request as ready for review October 4, 2023 13:21
@kukkok3 kukkok3 enabled auto-merge (squash) October 5, 2023 11:20
@kukkok3 kukkok3 added review me PR is ready for review and removed draft Draft labels Oct 5, 2023
@kukkok3 kukkok3 disabled auto-merge October 5, 2023 12:44
@kukkok3 kukkok3 added the do not merge yet PR is not ready to be merged yet label Oct 5, 2023
Copy link
Contributor

@nicopado nicopado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested by building on local machine

@kukkok3 kukkok3 merged commit 6ac3a00 into main Oct 5, 2023
28 checks passed
@kukkok3 kukkok3 deleted the feat-switch-to-f10-vitss branch October 5, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to be merged yet review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants