Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add description of the prometheus metrics used in jormungandr | NPG-000 #583

Merged
merged 4 commits into from
Oct 3, 2023
Merged

docs: Add description of the prometheus metrics used in jormungandr | NPG-000 #583

merged 4 commits into from
Oct 3, 2023

Conversation

saibatizoku
Copy link
Contributor

Description

Adds documentation for prometheus metrics.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saibatizoku saibatizoku added the review me PR is ready for review label Sep 27, 2023
@saibatizoku saibatizoku requested review from jmgilman, minikin and a team September 27, 2023 19:04
@saibatizoku saibatizoku self-assigned this Sep 27, 2023
@saibatizoku saibatizoku changed the title docs: Add description of the prometheus metrics used in jormungandr - NPG-000 docs: Add description of the prometheus metrics used in jormungandr | NPG-000 Sep 27, 2023
@minikin minikin enabled auto-merge (squash) September 28, 2023 07:36
Mr-Leshiy
Mr-Leshiy approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kukkok3
kukkok3 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin
Copy link
Collaborator

minikin commented Sep 29, 2023

@jmgilman, we need your feedback here, please.

@minikin
Copy link
Collaborator

minikin commented Oct 3, 2023

resolve https://github.com/input-output-hk/catalyst-world/issues/84

@minikin minikin disabled auto-merge October 3, 2023 09:15
@minikin minikin merged commit da44c0c into main Oct 3, 2023
5 checks passed
@minikin minikin deleted the docs-prometheus-metrics branch October 3, 2023 09:15
@stevenj stevenj added this to the F11-Launch milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukkok3 kukkok3 kukkok3 approved these changes

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@minikin minikin minikin approved these changes

@jmgilman jmgilman Awaiting requested review from jmgilman

Assignees

@saibatizoku saibatizoku

Labels
review me PR is ready for review
Projects
None yet
Milestone
F11-Launch
Development

Successfully merging this pull request may close these issues.
5 participants
@saibatizoku @minikin @Mr-Leshiy @kukkok3 @stevenj