Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Review's allocation generation | NPG-8066 #552

Merged
merged 7 commits into from
Sep 7, 2023
Merged

feat: Review's allocation generation | NPG-8066 #552

merged 7 commits into from
Sep 7, 2023

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Sep 5, 2023 •
edited
Loading

Description

  • Added new cli command for allocations generation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • test_allocations_generator

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Mr-Leshiy Mr-Leshiy marked this pull request as draft September 5, 2023 07:27
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review September 5, 2023 11:28
@Mr-Leshiy Mr-Leshiy self-assigned this Sep 5, 2023
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Sep 5, 2023
@minikin minikin enabled auto-merge (squash) September 5, 2023 11:33
coire1
coire1 previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@coire1 coire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a small typo for the ReviewManager class name.
Logic for allocation is good.

utilities/ideascale-importer/ideascale_importer/cli/reviews.py Outdated Show resolved Hide resolved
saibatizoku
saibatizoku previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Mr-Leshiy Mr-Leshiy dismissed stale reviews from saibatizoku and coire1 via 593525d September 5, 2023 14:02
coire1
coire1 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@coire1 coire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@minikin minikin merged commit 97a6074 into main Sep 7, 2023
27 checks passed
@minikin minikin deleted the feature/allocation-tool branch September 7, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coire1 coire1 coire1 approved these changes

@saibatizoku saibatizoku saibatizoku approved these changes

@stevenj stevenj Awaiting requested review from stevenj

@kukkok3 kukkok3 Awaiting requested review from kukkok3

@minikin minikin Awaiting requested review from minikin

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or

Assignees

@Mr-Leshiy Mr-Leshiy

Labels
review me PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mr-Leshiy @saibatizoku @coire1 @minikin