feat: Update catalyst-toolbox proposal-score command | NPG-7776
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Leshiy
requested review from
minikin,
kukkok3,
cong-or,
saibatizoku and
FelipeRosa
minikin
requested changes
Jul 28, 2023
src/catalyst-toolbox/catalyst-toolbox/src/proposal_score/store.rs
Outdated
Show resolved
Hide resolved
minikin
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified
proposal-scorecli command, so now it is not inserted proposal's scores directly into the database.It inserts data into the provided
proposals.jsonfile.This update will simplify deployment process so the flow would the following:
proposals.jsonfilereviews.csvfile with all reviewsproposal-scorecommand and providereviews.csvas an input,proposals.jsonas an input and as an output of the updated proposals with the added scores data