-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Audit tooling | NPG-6520 #490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial sketch
initial sketch
cross reference replayed tally fragments vs official results
re-write recovery tool
replay fragments
re-write recovery tool
re-write recovery tool
re-write recovery tool
re-write recovery tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
audit fragments have no concept of time, we assume fragments are correct as the nodes have reached consensus and filtered fragments correctly.
given a casters pub key find all voting metadata
fragment replay has no concept of time. Remove in vote time checks when feature audit enabled.
proposal id in question must use member public key associated with its voteplan for decryption.
only run in-vote-time tests when audit flag is NOT enabled.
only run in-vote-time tests when audit flag is NOT enabled.
…udit flag is NOT enabled.
stevenj
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
error: failed to compile `cargo-make v0.36.12`, intermediate artifacts can be found at `/tmp/cargo-installsZuhxD`
Caused by:
package `time v0.3.24` cannot be built because it requires rustc 1.67.0 or newer, while the currently active rustc version is 1.65.0
Try re-running cargo install with `--locked`
Error: Process completed with exit code 101. Should we consider updating to the latest stable ps: I created a patch and looks like there are some things that we need to address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More granular docs will follow in another PR.
Keep in my mind, code from recover.rs has been salvaged from other parts of the code base...