Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Audit tooling | NPG-6520 #490

Merged
merged 61 commits into from
Aug 2, 2023
Merged

feat: Audit tooling | NPG-6520 #490

merged 61 commits into from
Aug 2, 2023

Conversation

cong-or
Copy link
Contributor

@cong-or cong-or commented Jul 27, 2023

More granular docs will follow in another PR.

Keep in my mind, code from recover.rs has been salvaged from other parts of the code base...

cross reference replayed tally fragments vs official results
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
user can verify with tally cli tool
audit fragments have no concept of time, we assume fragments are correct as the nodes have reached consensus and filtered fragments correctly.
given a casters pub key find all voting metadata
@cong-or cong-or removed the do not review yet Do not review yet label Jul 29, 2023
@cong-or cong-or requested a review from stevenj July 29, 2023 12:58
@cong-or cong-or marked this pull request as ready for review July 29, 2023 14:13
@minikin minikin added the review me PR is ready for review label Jul 31, 2023
@minikin minikin enabled auto-merge (squash) July 31, 2023 10:14
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin
Copy link
Collaborator

minikin commented Aug 1, 2023

@cong-or

error: failed to compile `cargo-make v0.36.12`, intermediate artifacts can be found at `/tmp/cargo-installsZuhxD`

Caused by:
  package `time v0.3.24` cannot be built because it requires rustc 1.67.0 or newer, while the currently active rustc version is 1.65.0
  Try re-running cargo install with `--locked`
Error: Process completed with exit code 101.

Should we consider updating to the latest stable 1.71.0 ?

ps: I created a patch and looks like there are some things that we need to address.

@minikin minikin merged commit fc46799 into main Aug 2, 2023
25 checks passed
@minikin minikin deleted the audit-tooling branch August 2, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants