Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove id from diddoc service encoding #17

Merged
merged 2 commits into from
Feb 26, 2024
Merged

fix: remove id from diddoc service encoding #17

merged 2 commits into from
Feb 26, 2024

Conversation

cristianIOHK
Copy link
Contributor

Overview

This pr fixes did peer creation for the new specification. With @goncalo-frade-iohk's help, we found an issue on the diddoc service encoding logic where the ID was included when it shouldn't.
This is fixed now.

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • [] Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • [] My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 23, 2024 •
edited
Loading

Unit Test Results

97 tests   97 ✅  2s ⏱️
 9 suites   0 💤
 9 files     0 ❌

Results for commit 08ad65a.

♻️ This comment has been updated with latest results.

@cristianIOHK cristianIOHK merged commit 2298cfc into main Feb 26, 2024
3 checks passed
@cristianIOHK cristianIOHK deleted the fix_did_peer branch February 26, 2024 18:43
atala-dev added a commit that referenced this pull request Feb 26, 2024
@atala-dev
chore(release): cut wallet sdk version 1.1.1
3ff284d 
## [1.1.1](v1.1.0...v1.1.1) (2024-02-26)

### Bug Fixes

* remove id from diddoc service encoding ([#17](#17)) ([2298cfc](2298cfc))
github-actions bot pushed a commit that referenced this pull request Feb 26, 2024
@atala-dev
feat(docs): (3ff284d) chore(release): cut wallet sdk version 1.1.1
ff200b4 
## [1.1.1](v1.1.0...v1.1.1) (2024-02-26)

### Bug Fixes

* remove id from diddoc service encoding ([#17](#17)) ([2298cfc](2298cfc))
github-actions bot pushed a commit that referenced this pull request Feb 26, 2024
@cristianIOHK
feat(docs): (2298cfc) fix: remove id from diddoc service encoding (#17)
c10a024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

@curtis-h curtis-h Awaiting requested review from curtis-h

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristianIOHK @hamada147