Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new column menu #4428

Merged
merged 86 commits into from
Sep 23, 2024
Merged

feat: add new column menu #4428

merged 86 commits into from
Sep 23, 2024

Conversation

laila-rin
Copy link
Collaborator

Description

Changed column menu layout to new design.

Changelog

  • added colorpicker dropdown
  • added MiniMenu and removed hardcoded items in column settings menu
  • added horizontally/vertically flipped version for mobile

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

image image

@laila-rin
create colorPicker dropdown
1a713d8
@laila-rin
quick safe
6a29204
@laila-rin
change order and a little bit of ❇️ visual spice ❇️
3bc3a8d
@laila-rin
add rounded corners to pretty up the color picker drop down
64ebeea
@laila-rin
add in close button
545e066
@laila-rin
add functionality to close button
06367e4
@laila-rin
clean up
3a71296
@laila-rin
adjusting visuals to fit figma design
51d8627
@laila-rin
quick save
c87b6b0
@laila-rin
transfer css classes from ColumnSettings.scss to ColorPicker.scss and…
61cd54d 
… a little clean up
@laila-rin
little more clean up
e1e3d08
@laila-rin
revert changes in docker-compose.yml
8c27b0c
@laila-rin
fix color picker border
0b680f3
@laila-rin
try add tooltip
a342928
@laila-rin
rotate settings icon, but the girl is still dancing when hovering
aebd6f2
@laila-rin
integrate minimenu into columnsettings
8d9c3f1
@laila-rin
change colorpicker layout
87f7fb2
@laila-rin
remove hardcoded colors in colorpicker
f2fbc70
@laila-rin
fix colorpicker appearence and z-index
d3c350e
@laila-rin
move menu to right spot
f196d0e
@laila-rin
add transform mixin for minimenu
77ce2f5
@laila-rin
add dark theme to colorPicker
a7dc315
@laila-rin
rotate back edit icon
8b352e1
@laila-rin
change tooltip color
b51563c
@laila-rin
add dark theme to minimenu
a30d6f0
@laila-rin
Merge remote-tracking branch 'refs/remotes/origin/main' into js/new-c…
3962f24 
…olumn-menu

# Conflicts:
#	src/components/Column/ColumnSettings.tsx
@laila-rin
fix columnsettings z index
533d7aa
@laila-rin
add flag for horizontal and vertical arrangement to colorpicker
53eda70
@laila-rin
start adding mobile view to change into vertical view
7028f12
@laila-rin
add rotation flags to mini menu and color picker
33a702e
Schwehn42
Schwehn42 reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nitpicks :)

src/components/ColorPicker/ColorPicker.tsx Outdated Show resolved Hide resolved
src/components/ColorPicker/ColorPicker.tsx Outdated Show resolved Hide resolved
src/components/ColorPicker/ColorPicker.scss Outdated Show resolved Hide resolved
src/components/ColorPicker/ColorPicker.scss Outdated Show resolved Hide resolved
src/components/ColorPicker/ColorPicker.tsx Outdated Show resolved Hide resolved
src/components/Column/ColumnSettings.tsx Outdated Show resolved Hide resolved
src/components/Column/ColumnSettings.tsx Outdated Show resolved Hide resolved
src/components/Column/ColumnSettings.tsx Outdated Show resolved Hide resolved
src/components/Column/ColumnSettings.tsx Outdated Show resolved Hide resolved
src/components/Column/ColumnSettings.tsx Outdated Show resolved Hide resolved
@Schwehn42 Schwehn42 added Changes Requested Changes requested by the reviewer and removed Review Needed This pull request is ready for review labels Sep 11, 2024
Schwehn42
Schwehn42 reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's not enough space, the menu looks like this:

Screenshot 2024-09-11 at 15 46 20

laila-rin and others added 11 commits September 12, 2024 18:05
@laila-rin laila-rin added Review Needed This pull request is ready for review and removed Changes Requested Changes requested by the reviewer labels Sep 13, 2024
Schwehn42
Schwehn42 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳
just one small thing, tabbing doesn't work in Firefox, however, I just noticed it also doesn't seem to work for note reactions, so I propose we create a separate issue to resolve both (edit: #4500).

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Sep 17, 2024
@github-actions GitHub Actions
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4428.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images

  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-2ccc2db

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-2ccc2db

@laila-rin laila-rin added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 924662e Sep 23, 2024
10 of 12 checks passed
@laila-rin laila-rin deleted the js/new-column-menu branch September 23, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandstetterm brandstetterm brandstetterm left review comments

@Schwehn42 Schwehn42 Schwehn42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laila-rin @Schwehn42 @brandstetterm