-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for generic OpenID Connect authentication provider #4401
Conversation
the icons seem to originate from Figma and are exported/converted manually. as i have not access to the sources, i have edited an SVG i found on the internet. you might want to create an original one in Figma; same as for the Google and Microsoft icons |
cool idea, skimming over it looks pretty good! i'll try to add a proper review in the coming days. |
3fb59bd
to
d460d33
Compare
this feature was tested and developed against dex-idp but should be generic/configurable enough, to work against any arbitrary identity provider. the requested scopes can be configured, while the read claims are still hardcoded.
d460d33
to
46730af
Compare
@mateo-ivc if you have time, could you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so far good to me.
Nice work :)
Description
implementation for another authentication provider;
a generic OIDC IDP (ory, dex, authelia, keycloak, zitadel, gitlab, gitea, ...)
this feature was tested and developed against dex-idp but should be generic/configurable enough, to work against any arbitrary identity provider.
the requested scopes can be configured, while the read claims are still hardcoded.
Changelog
Checklist
(Optional) Visual Changes