Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for generic OpenID Connect authentication provider #4401

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

UiP9AV6Y
Copy link
Contributor

Description

implementation for another authentication provider;
a generic OIDC IDP (ory, dex, authelia, keycloak, zitadel, gitlab, gitea, ...)

this feature was tested and developed against dex-idp but should be generic/configurable enough, to work against any arbitrary identity provider.

the requested scopes can be configured, while the read claims are still hardcoded.

Changelog

  • frontend: add login flow support for OpenID Connect
  • backend: add support for generic OIDC authentication

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@UiP9AV6Y
Copy link
Contributor Author

the icons seem to originate from Figma and are exported/converted manually. as i have not access to the sources, i have edited an SVG i found on the internet. you might want to create an original one in Figma; same as for the Google and Microsoft icons

@Schwehn42
Copy link
Collaborator

cool idea, skimming over it looks pretty good! i'll try to add a proper review in the coming days.

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Aug 12, 2024
this feature was tested and developed against dex-idp but should
be generic/configurable enough, to work against any arbitrary
identity provider.

the requested scopes can be configured, while the read claims
are still hardcoded.
@Schwehn42
Copy link
Collaborator

@mateo-ivc if you have time, could you take a look at this?

Copy link
Collaborator

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so far good to me.
Nice work :)

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Sep 24, 2024
@mateo-ivc mateo-ivc added this pull request to the merge queue Sep 25, 2024
Merged via the queue into inovex:main with commit 8c85938 Sep 25, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants