-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: less information sent per SessionUpdate (Backend) #4246
base: main
Are you sure you want to change the base?
Conversation
…ced here and not a whole user
… specific session
…g foreward, only data of the current session is published to the current board
This comment has been minimized.
This comment has been minimized.
🐙 OctomindTest Report: 7/14 successful.
commit sha: 4fcad87 |
The deployment to the dev cluster was successful. You can find the deployment here: https://4246.development.scrumlr.fra.ics.inovex.io Deployed Images
|
@BenedictHomuth I'll do the frontend part as soon as all/most of the other active PRs are merged into main – I'm worried that with such a change, there are just too many conflicts bound to happen 😅 |
Definitely worth its own release 😅 |
Update: I'm going to take a stab at this after the new store (related to #4423) is implemented. |
Description
Reduced the amount of information sent when a participant either changes his appearance or status on a board – as mention in #4217.
Before a
PARTICIPANT_UPDATED
event was published containing all information (account and board session). This is now split into two:PARTICIPANT_UPDATED
PARTICIPANT_SESSION_UPDATED
Changelog
UpdatedUser
function to publish only adto.User
to realtimedto.BoardSession
– removing the whole account data and just leaving the id for identificationdto.BoardSession
to realtime for one board going forewarddto.BoardSession
Next Steps
Since this is a breaking change, we need to modify the frontend to accommodate the backend changes. From my perspective either use this branch directly to make changes to the frontend or create a branch based on this one.
After the frontend changes are done, all tests should work again. For now, since I did not change the frontend, those tests obviously fail.
Checklist