-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removal of session and session-request observer #4203
Conversation
… service layer. since we now need the realtime package in the user service I added it
🐙 OctomindTest Report: 0/14 successful.
commit sha: 3b7dc2b |
The deployment to the dev cluster was successful. You can find the deployment here: https://4203.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 12/14 successful.
commit sha: ec5026c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏽
Co-authored-by: Benedict Homuth <[email protected]>
Description
Removed the session and session request observer and moved the corresponding logic into the service layer.
Two more changes:
Created one new db function, since before this logic was written plainly in the observer.
Since user updates need to be published to all board members (e.g. on name or appearance change) I added the realtime package to the UserService. Before it was implicitly handled in one of the observers.
Changelog
Checklist
(Optional) Visual Changes