Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removal of session and session-request observer #4203

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

BenedictHomuth
Copy link
Collaborator

@BenedictHomuth BenedictHomuth commented Jun 7, 2024

Description

Removed the session and session request observer and moved the corresponding logic into the service layer.

Two more changes:

  1. Created one new db function, since before this logic was written plainly in the observer.

  2. Since user updates need to be published to all board members (e.g. on name or appearance change) I added the realtime package to the UserService. Before it was implicitly handled in one of the observers.

Changelog

  • removed session and session observer
  • moved logic into corresponding service layers
  • Created a new db function which fetches all currently connected sessions of a given user
  • Added the realtime package to the UserService

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

… service layer. since we now need the realtime package in the user service I added it
@BenedictHomuth BenedictHomuth self-assigned this Jun 7, 2024
Copy link

octomind-dev bot commented Jun 7, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 3b7dc2b

@BenedictHomuth BenedictHomuth added the Review Needed This pull request is ready for review label Jun 7, 2024
@BenedictHomuth BenedictHomuth changed the title chore:removal of session and session-request observer chore: removal of session and session-request observer Jun 7, 2024
Copy link

github-actions bot commented Jun 8, 2024

The deployment to the dev cluster was successful. You can find the deployment here: https://4203.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-ec5026c

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-ec5026c

Copy link

octomind-dev bot commented Jun 8, 2024

🐙 Octomind

Test Report: 12/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Failed ❌ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: ec5026c

Copy link
Collaborator

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏽

@BenedictHomuth BenedictHomuth added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 1fd33b7 Jun 18, 2024
6 checks passed
@BenedictHomuth BenedictHomuth deleted the bh/removal-session-observer branch June 18, 2024 12:48
BenedictHomuth added a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants