Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alignment of votes and icons within notes of the stack view #3908

Merged
merged 20 commits into from
Mar 7, 2024

Conversation

brandstetterm
Copy link
Collaborator

@brandstetterm brandstetterm commented Feb 27, 2024

Description

The original problem has been that the icons of the various buttons within a note (e.g. add vote, unstack note, delete note) in the stack view were not aligned. However, further problems were subsequently found. For example, I noticed that the buttons have different sizes and that the tooltips of the delete and unstack buttons also overflow outside the screen on narrower screens. For this reason, I've tried to come up with a better alternative for the buttons within the notes.

Fixes #3843

Changelog

  • Use the same height and width for all buttons within the notes (e.g. add vote button, delete button, unstack button)
  • Replace the tooltip buttons with normal buttons in combination with our new tooltip component

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@brandstetterm brandstetterm self-assigned this Feb 27, 2024
@inovex inovex deleted a comment from octomind-dev bot Mar 7, 2024
@inovex inovex deleted a comment from octomind-dev bot Mar 7, 2024
@inovex inovex deleted a comment from octomind-dev bot Mar 7, 2024
@inovex inovex deleted a comment from github-actions bot Mar 7, 2024
@inovex inovex deleted a comment from octomind-dev bot Mar 7, 2024
Copy link

octomind-dev bot commented Mar 7, 2024

🐙 Octomind

Test Report: 11/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 341f000

Copy link

github-actions bot commented Mar 7, 2024

The deployment to the dev cluster was successful. You can find the deployment here: https://3908.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-26e1a27

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-26e1a27

Copy link

octomind-dev bot commented Mar 7, 2024

🐙 Octomind

Test Report: 10/13 successful.

description status details
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
get started Passed ✅ click
share_session Failed ❌ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 26e1a27

@brandstetterm brandstetterm marked this pull request as ready for review March 7, 2024 15:54
@brandstetterm brandstetterm merged commit f11322f into main Mar 7, 2024
4 of 5 checks passed
@brandstetterm brandstetterm deleted the mb/note-icon-alignment branch March 7, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment of votes and icons in note
1 participant