Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Support request token #28

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Chore: Support request token #28

merged 5 commits into from
Aug 26, 2024

Conversation

lucaswilliamgomes
Copy link
Contributor

No description provided.

@lucaswilliamgomes lucaswilliamgomes self-assigned this Aug 14, 2024
@lucaswilliamgomes lucaswilliamgomes changed the title Chore: Removing required installation id on client methods Chore: Support request token Aug 14, 2024
julianalucena
julianalucena requested changes Aug 19, 2024
View reviewed changes
spec/incognia_spec.rb Outdated Show resolved Hide resolved
lib/incognia_api/api.rb Outdated Show resolved Hide resolved
@marcelscr
Copy link

Mudflap is interested on using this feature :gogo:

julianalucena
julianalucena reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@julianalucena julianalucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions regarding received parameters that I think will make code more readable and will require less changes when request_token starts to be required.

lib/incognia_api/api.rb Outdated Show resolved Hide resolved
lib/incognia_api/api.rb Outdated Show resolved Hide resolved
lib/incognia_api/api.rb Outdated Show resolved Hide resolved
@lucaswilliamgomes lucaswilliamgomes merged commit d8c97a1 into main Aug 26, 2024
2 checks passed
@lucaswilliamgomes lucaswilliamgomes deleted the feat/support-request-token branch August 26, 2024 23:16
@lucaswilliamgomes lucaswilliamgomes restored the feat/support-request-token branch August 26, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianalucena julianalucena julianalucena approved these changes

@guiocavalcanti guiocavalcanti Awaiting requested review from guiocavalcanti guiocavalcanti is a code owner

@ottony ottony Awaiting requested review from ottony ottony is a code owner

@figueredo figueredo Awaiting requested review from figueredo

Assignees

@lucaswilliamgomes lucaswilliamgomes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucaswilliamgomes @marcelscr @julianalucena