refactor(stdpay): add oid, timestamp to StdPayGetParamsInput

inicisjs · Jun 17, 2021 · 6933fc0 · 6933fc0
1 parent e04da17
commit 6933fc0
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7,722 deletions.
diff --git a/lib/interfaces/stdpay.interface.ts b/lib/interfaces/stdpay.interface.ts
@@ -17,6 +17,14 @@ export type StdPayGetParamsInput = {
    * @default '' */
   gopaymethod?: string;
 
+  /** 주문번호 (* 반드시 Unique 값으로 생성 (거래추적 시 사용됨))
+   * @default `${timestamp}${getRandomString(4)}` */
+  oid?: string;
+
+  /** 타임스템프 [TimeInMillis(Long형)]
+   * @default new Date().getTime() */
+  timestamp?: number;
+
   /** 결제 금액 (* 숫자만, 1달러는 100으로 시작) */
   price: number;
 
@@ -56,12 +64,6 @@ export type StdPayRequestParams = Pick<InicisOptions, 'mid'> &
     /** 전문 버전 ["1.0" 고정] */
     version: '1.0';
 
-    /** 주문번호 (* 반드시 Unique 값으로 생성 (거래추적 시 사용됨)) */
-    oid: string;
-
-    /** 타임스템프 [TimeInMillis(Long형)] */
-    timestamp: number;
-
     /** SHA256 Hash값 [대상: oid, price, timestamp] */
     signature: string;
 

diff --git a/lib/resources/stdpay.resource.ts b/lib/resources/stdpay.resource.ts
@@ -14,21 +14,24 @@ export class InicisStdpay {
   constructor(private readonly inicisOptions: InicisOptions) {}
 
   getParams(input: StdPayGetParamsInput): StdPayRequestParams {
-    const timestamp = new Date().getTime();
-    const oid = `${timestamp}${getRandomString(4)}`;
+    const {
+      timestamp = new Date().getTime(),
+      oid = `${timestamp}${getRandomString(4)}`,
+      price,
+    } = input;
 
     const { mid, signkey } = this.inicisOptions;
 
     const mKey = hash(signkey, 'sha256');
     const signature = sign({
       oid,
-      price: input.price,
+      price,
       timestamp,
     });
 
     return {
-      ...input,
       ...STDPAY_BASE_PARAMS,
+      ...input,
       mid,
       oid,
       timestamp,