Skip to content

Commit

Permalink
[chore] remove errnextnilconsumer tests (open-telemetry#31304)
Browse files Browse the repository at this point in the history
**Description:**
We are looking to deprecate component.ErrNilNextConsumer and have
pipelines check it rather than set it the expectation on every component
that the next component may be nil.

See open-telemetry/opentelemetry-collector#9526
for context.
  • Loading branch information
atoulme committed Feb 22, 2024
1 parent 0c378db commit ee728f7
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 40 deletions.
17 changes: 0 additions & 17 deletions receiver/splunkenterprisereceiver/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,23 +66,6 @@ func TestCreateMetricsReceiver(t *testing.T) {
require.NoError(t, err, "failed to create metrics receiver with valid inputs")
},
},
{
desc: "Missing consumer",
run: func(t *testing.T) {
t.Parallel()

cfg := createDefaultConfig().(*Config)

_, err := createMetricsReceiver(
context.Background(),
receivertest.NewNopCreateSettings(),
cfg,
nil,
)

require.Error(t, err, "created metrics receiver without consumer")
},
},
}
for _, test := range tests {
t.Run(test.desc, test.run)
Expand Down
18 changes: 0 additions & 18 deletions receiver/webhookeventreceiver/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,24 +47,6 @@ func TestCreateLogsReceiver(t *testing.T) {
require.NoError(t, err, "failed to create logs receiver")
},
},
{
desc: "Missing consumer",
run: func(t *testing.T) {
t.Parallel()

cfg := createDefaultConfig().(*Config)
cfg.Endpoint = "localhost:8080"
require.NoError(t, cfg.Validate(), "error validating default config")

_, err := createLogsReceiver(
context.Background(),
receivertest.NewNopCreateSettings(),
cfg,
nil,
)
require.Error(t, err, "Succeeded in creating a receiver without a consumer")
},
},
}

for _, test := range tests {
Expand Down
5 changes: 0 additions & 5 deletions receiver/webhookeventreceiver/receiver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ func TestCreateNewLogReceiver(t *testing.T) {
},
consumer: consumertest.NewNop(),
},
{
desc: "Missing consumer fails",
cfg: *defaultConfig,
err: errNilLogsConsumer,
},
}

for _, test := range tests {
Expand Down

0 comments on commit ee728f7

Please sign in to comment.