[chore][receiver/activedirectoryds] Fix lint on Windows issues (open-…

…telemetry#29796)

**Description:**
Fixing lint issues when GOOS=windows. This is in preparation to
eventually include lint with GOOS=windows as part of CI.

**Link to tracking Issue:**
N/A

**Testing:**
`make` on component folder on a Windows box

**Documentation:**
N/A

receiver/activedirectorydsreceiver/counters.go

@@ -24,9 +24,9 @@ const (
 	draOutboundObjects                     = "DRA Outbound Objects/sec"
 	draInboundProperties                   = "DRA Inbound Properties Total/sec"
 	draOutboundProperties                  = "DRA Outbound Properties/sec"
-	draInboundValuesDNs                    = "DRA Inbound Values (DNs only)/sec"
+	draInboundValuesDNs                    = "DRA Inbound Values (DNs only)/sec" //revive:disable-line:var-naming
 	draInboundValuesTotal                  = "DRA Inbound Values Total/sec"
-	draOutboundValuesDNs                   = "DRA Outbound Values (DNs only)/sec"
+	draOutboundValuesDNs                   = "DRA Outbound Values (DNs only)/sec" //revive:disable-line:var-naming
 	draOutboundValuesTotal                 = "DRA Outbound Values Total/sec"
 	draPendingReplicationOperations        = "DRA Pending Replication Operations"
 	draSyncFailuresSchemaMismatch          = "DRA Sync Failures on Schema Mismatch"

receiver/activedirectorydsreceiver/factory_windows.go

@@ -21,7 +21,7 @@ import (
 var errConfigNotActiveDirectory = fmt.Errorf("config is not valid for the '%s' receiver", metadata.Type)
 
 func createMetricsReceiver(
-	ctx context.Context,
+	_ context.Context,
 	params receiver.CreateSettings,
 	rConf component.Config,
 	consumer consumer.Metrics,

receiver/activedirectorydsreceiver/scraper.go

@@ -32,7 +32,7 @@ func newActiveDirectoryDSScraper(mbc metadata.MetricsBuilderConfig, params recei
 	}
 }
 
-func (a *activeDirectoryDSScraper) start(ctx context.Context, host component.Host) error {
+func (a *activeDirectoryDSScraper) start(_ context.Context, _ component.Host) error {
 	watchers, err := getWatchers(defaultWatcherCreater{})
 	if err != nil {
 		return fmt.Errorf("failed to create performance counter watchers: %w", err)
@@ -45,7 +45,7 @@ func (a *activeDirectoryDSScraper) start(ctx context.Context, host component.Hos
 	return nil
 }
 
-func (a *activeDirectoryDSScraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
+func (a *activeDirectoryDSScraper) scrape(_ context.Context) (pmetric.Metrics, error) {
 	var multiErr error
 	now := pcommon.NewTimestampFromTime(time.Now())
 
@@ -103,6 +103,7 @@ func (a *activeDirectoryDSScraper) scrape(ctx context.Context) (pmetric.Metrics,
 		a.mb.RecordActiveDirectoryDsReplicationPropertyRateDataPoint(now, draOutboundProperties, metadata.AttributeDirectionSent)
 	}
 
+	//revive:disable-next-line:var-naming
 	draInboundValuesDNs, dnsErr := a.w.Scrape(draInboundValuesDNs)
 	multiErr = multierr.Append(multiErr, dnsErr)
 	if dnsErr == nil {
@@ -116,6 +117,7 @@ func (a *activeDirectoryDSScraper) scrape(ctx context.Context) (pmetric.Metrics,
 		a.mb.RecordActiveDirectoryDsReplicationValueRateDataPoint(now, otherValuesInbound, metadata.AttributeDirectionReceived, metadata.AttributeValueTypeOther)
 	}
 
+	//revive:disable-next-line:var-naming
 	draOutboundValuesDNs, dnsErr := a.w.Scrape(draOutboundValuesDNs)
 	multiErr = multierr.Append(multiErr, dnsErr)
 	if dnsErr == nil {
@@ -245,10 +247,10 @@ func (a *activeDirectoryDSScraper) scrape(ctx context.Context) (pmetric.Metrics,
 	}
 
 	if multiErr != nil {
-		return pmetric.Metrics(a.mb.Emit()), scrapererror.NewPartialScrapeError(multiErr, len(multierr.Errors(multiErr)))
+		return a.mb.Emit(), scrapererror.NewPartialScrapeError(multiErr, len(multierr.Errors(multiErr)))
 	}
 
-	return pmetric.Metrics(a.mb.Emit()), nil
+	return a.mb.Emit(), nil
 }
 
 func (a *activeDirectoryDSScraper) shutdown(_ context.Context) error {