Add new modules in baker_types to prepare for java17 #1478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since UUID fields, Date/DateTime fields are final baker cannot instantiate them in the pojo way. RecordMod uses the new record class to instantiate the obejct properly TODO: unittesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Java 17 support to add new modules for java.time.*, java.util.UUID and java.lang.Record
In Java17 it's not allowed anymore to set values to final fields, instead new modules are created for classes like java.time.*, java.util.UUID and java records to instantiate the object in a non reflective way.
Modules can be extended to add new types.
JavaTimeModule maps LocalDate and LocalDateTime to an epochMillis long value, (and back)
UUIDModule converts the UUID type into a string (and back)
Record type uses the new Java 17 records to read and instantiate a record using Class.isRecord (will fail on java 11) and uses getRecordComponents()[].