Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse memory usage by ProcessIndex Actors via reusing cache between s… #1173

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stasimus
Copy link
Contributor

@stasimus stasimus commented Feb 3, 2022

…hards on the same node.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #1173 (90254bf) into master (61eb540) will increase coverage by 0.23%.
The diff coverage is 71.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
+ Coverage   81.01%   81.25%   +0.23%     
==========================================
  Files         124      125       +1     
  Lines        3987     3990       +3     
  Branches      129      132       +3     
==========================================
+ Hits         3230     3242      +12     
+ Misses        757      748       -9     
Impacted Files Coverage Δ
...e/src/main/scala/com/ing/bakery/baker/Bakery.scala 0.00% <0.00%> (ø)
...runtime/akka/actor/ClusterBakerActorProvider.scala 17.85% <0.00%> (ø)
...kka/actor/process_index/ProcessIndexProtocol.scala 100.00% <ø> (ø)
...r/serialization/BakerTypedProtobufSerializer.scala 100.00% <ø> (ø)
...a/com/ing/baker/runtime/akka/AkkaBakerConfig.scala 76.05% <77.77%> (+0.29%) ⬆️
...n/scala/com/ing/baker/runtime/akka/AkkaBaker.scala 79.16% <100.00%> (+0.14%) ⬆️
...r/runtime/akka/actor/LocalBakerActorProvider.scala 100.00% <100.00%> (ø)
...e/akka/actor/process_index/ProcessIndexActor.scala 82.25% <100.00%> (ø)
...e/akka/actor/process_index/ProcessIndexProto.scala 99.52% <100.00%> (+5.18%) ⬆️
...runtime/akka/actor/process_index/RecipeCache.scala 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61eb540...90254bf. Read the comment docs.

wwbakker and others added 5 commits February 9, 2022 18:53
* - Updated dependencies found by scala-steward which did not fail CI build.

* - Updated mockito and other dependencies to support java 11.
- Updated github workflow to use JDK11 for build.

* - Fix issue due to pull from master.

Co-authored-by: Wessel W. Bakker <[email protected]>
# Conflicts:
#	core/akka-runtime/src/test/scala/com/ing/baker/runtime/akka/actor/process_index/ProcessIndexActorSpec.scala
wwbakker
wwbakker previously approved these changes Feb 10, 2022
# Conflicts:
#	core/akka-runtime/src/main/scala/com/ing/baker/runtime/akka/AkkaBaker.scala
#	core/akka-runtime/src/test/scala/com/ing/baker/runtime/akka/actor/process_index/ProcessIndexActorSpec.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants