-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package the language server for publishing in NPM #1134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I wonder why the diff size is 12k?
@@ -0,0 +1,22 @@ | |||
# Quint Language Server | |||
|
|||
[![npm (scoped)](https://img.shields.io/npm/v/@informalsystems/quint-language-server)](https://www.npmjs.com/package/@informalsystems/quint-language-server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link looks like two links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the badge thing, I believe the first one gets the image and the second is the actual link that opens when you click the badge. I just copied from quint's readme and changed the links.
It's only the |
Looks like indentation changed from 8 to 2 blanks 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Hello
I want to publish our language server to NPM in order to make it easy to install and run from the LSP client for Emacs.
This shouldn't change anything about how we publish the VSCode extension, at least for now. I'm also not automating the release process yet. I plan to run a manual release once this PR is approved.
CHANGELOG.md
for any new functionalityREADME.md
updated for any listed functionality