Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package the language server for publishing in NPM #1134

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

bugarela
Copy link
Collaborator

Hello :octocat:

I want to publish our language server to NPM in order to make it easy to install and run from the LSP client for Emacs.

This shouldn't change anything about how we publish the VSCode extension, at least for now. I'm also not automating the release process yet. I plan to run a manual release once this PR is approved.

  • Tests added for any new code
  • Documentation added for any new functionality
  • Entries added to the respective CHANGELOG.md for any new functionality
  • Feature table on README.md updated for any listed functionality

@bugarela bugarela self-assigned this Aug 31, 2023
Copy link
Contributor

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wonder why the diff size is 12k?

@@ -0,0 +1,22 @@
# Quint Language Server

[![npm (scoped)](https://img.shields.io/npm/v/@informalsystems/quint-language-server)](https://www.npmjs.com/package/@informalsystems/quint-language-server)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link looks like two links?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the badge thing, I believe the first one gets the image and the second is the actual link that opens when you click the badge. I just copied from quint's readme and changed the links.

@bugarela
Copy link
Collaborator Author

bugarela commented Sep 1, 2023

Looks good! I wonder why the diff size is 12k?

It's only the package.lock file causing that huge diff. Idk why it changed so much, but since I renamed the package itself (from quint-lsp-server to quint-language-server, it might have affected the hashes of every single dependency or something like that.

@thpani
Copy link
Contributor

thpani commented Sep 4, 2023

It's only the package.lock file causing that huge diff. Idk why it changed so much

Looks like indentation changed from 8 to 2 blanks 😄

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bugarela bugarela merged commit cc8bcc8 into main Sep 5, 2023
15 checks passed
@bugarela bugarela deleted the gabriela/language-server-packaging branch September 5, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants