-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Apalache server #1115
Merged
Merged
Manage Apalache server #1115
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
265d606
Move connection attempt into `connect()`
thpani 2db5feb
Manage Apalache server
thpani 10d7ee7
Bump tagged Apalache version
thpani 88affaf
Bump Node.js to v18 in GH workflows
thpani c5c67ba
Use `find` instead of `filter`
thpani 1f4d6b2
Use `tar` instead of `tar-fs`
thpani 1a6a1d5
Rework retry logic
thpani ce89570
Update integration tests
thpani 5980f16
Handle error fetching GH releases
thpani 97bcb15
Update changelog
thpani d2045ae
Clean up dependencies
thpani e78648f
Lift code out of async function
thpani 154604d
Improve console output
thpani 0e10594
Fix integration test
thpani c58464f
Handle ESRCH on process.kill()
thpani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a feature add, not a breaking change, iiuc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use these categories in a way that diverges from https://keepachangelog.com/?
They simple state
Whether this is a new feature, or modification of an existing one is largely up to interpretation. I'd treat it as a changed feature, as it does not expose additional core functionality. Rather, it improves UX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge this PR, since Igor wanted to send install instructions for the summer school.
LMK if I should follow up with an updated changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I take "changes for existing functionality" to entail breaking changes. Otherwise, none of the categories entail breaking changes, and I also don't know how you can change existing functionality without that possibly breaking previous expectation about the API. That said, I can see how disagreement of the interpretation here is possible.
Apparently there has been a long-onging debate about this, lol: olivierlacan/keep-a-changelog#41
Perhaps we should add a "Breaking changes" section?
I don't think my view is not widely enough shared to require any change to your entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see – yeah, it looks like the keepachangelog sections are a bit orthogonal to indicating breaking changes. Incidentally, also
Removed
may indicate a breaking change, so I guess in this taxonomy breaking changes are scattered across sections.If we want to list breaking changes, we can either prefix individual items with a qualifier or break them into a separate section, as you suggested.