Add parsing of sum type declarations #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
force-pushed
the
sf/1082/syntax
branch
from
7bd63a1
to
0dd0d29
Compare
added 2 commits
August 2, 2023 09:11
…d-ids Require record fields to be simple identifiers
added 7 commits
August 2, 2023 15:52
Not sure why this updating. Tests succeed whether this file is updated or not. But, well, it's up to date now :)
shonfeder
force-pushed
the
sf/1082/syntax
branch
from
0dd0d29
to
c52028b
Compare
thpani
approved these changes
Aug 3, 2023
Comment on lines
+136
to
+138
| type T = | ||
| | A | ||
| | B(int) |
There was a problem hiding this comment.
Should we also test type T = A | B(int)?
There was a problem hiding this comment.
Good call! I've added this :)
|
Thanks for the review! |
shonfeder
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Add syntax for sum type declarations * Add parser generator updates * Adapt flattening and graphics for sum types * Add unit test for sum type declaration parsing * Update the super spec Not sure why this updating. Tests succeed whether this file is updated or not. But, well, it's up to date now :) * Add test for IRPrinting
shonfeder
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Add syntax for sum type declarations * Add parser generator updates * Adapt flattening and graphics for sum types * Add unit test for sum type declaration parsing * Update the super spec Not sure why this updating. Tests succeed whether this file is updated or not. But, well, it's up to date now :) * Add test for IRPrinting
shonfeder
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Add syntax for sum type declarations * Add parser generator updates * Adapt flattening and graphics for sum types * Add unit test for sum type declaration parsing * Update the super spec Not sure why this updating. Tests succeed whether this file is updated or not. But, well, it's up to date now :) * Add test for IRPrinting
shonfeder
pushed a commit
that referenced
this pull request
Aug 5, 2023
These changes address the comments from #1088 I had fixed all of these, but then merged the PR without pushing my fixes.
shonfeder
pushed a commit
that referenced
this pull request
Aug 5, 2023
These changes address the comments from #1088 I had fixed all of these, but then merged the PR without pushing my fixes.
shonfeder
pushed a commit
that referenced
this pull request
Aug 7, 2023
These changes address the comments from #1088 I had fixed all of these, but then merged the PR without pushing my fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the type declaration part of #1082.
This adds support for the sum type declaration syntax proposed in #1062.
The most interesting part of these changes is the addition of the IR constructs
to represent the declaration of sum types. This includes a specialized
variant of the row types allowing us to statically enforce that the rows of a
variant type cannot be open. See the discussion on #1062 for the motivation for
this design decision.
Note that we do not add a parsing rule to
typefor sum types. This reflectsthe fact that sum types can only be referenced by their defined name: anonymous
sum types are not supported.
Note that this PR is into the
sf/sum-typefeature branch.CHANGELOG.mdfor any new functionalityREADME.mdupdated for any listed functionality