Refactor value generators in the simulator #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konnov
commented
Jul 19, 2023
| ) as BS from "./BinSearch" | ||
| export BS.* |
There was a problem hiding this comment.
@thpani did I just break the apalache integration?
There was a problem hiding this comment.
Yeah, although I don't understand why it breaks with the export 😂
There was a problem hiding this comment.
Let's maybe disable this test for now, as it waiting for the fix similar to #1051
thpani
approved these changes
Jul 20, 2023
| // An infinite set, pick an integer from the range [-2^255, 2^255). | ||
| // TODO: make it a configurable parameter: | ||
| // https://github.com/informalsystems/quint/issues/279 | ||
| .or(just(-(2n ** 255n) + this.rand(2n ** 256n))) |
There was a problem hiding this comment.
Can't the infinte set be Nat and shouldn't the lower bound then be non-negative?
There was a problem hiding this comment.
Yep, the implementation of pick for Int/Nat checks that and uses the absolute value in case of Nat. I just do not want to differentiate them here.
There was a problem hiding this comment.
Okay. Maybe leave a comment then, so it's not confusing in the future?
Co-authored-by: Thomas Pani <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #954. To support generation of maps over infinite co-domains, I had to refactor the interface of
pickinRuntimeValue. I like the new interface better, as it clearly exposes an iterator instead of doing tricky arithmetic over indices.This is a breaking change. Since it changes how
oneOf()picks values, the seeds in the tests are not valid anymore.I have an impression that the simulator is slower now. Have to do some measurements.CHANGELOG.mdfor any new functionality