Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output the execution stack on undefined values in REPL #1056

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

konnov
Copy link
Contributor

@konnov konnov commented Jul 18, 2023

This is a quality of life improvement in REPL. I've noticed that I would usually like to see an execution trace when a test is failing in REPL, when setting .verbosity to 3-4. This is what this PR does.

  • Tests added for any new code
  • Entries added to the respective CHANGELOG.md for any new functionality

@konnov konnov requested review from bugarela and thpani July 18, 2023 14:17
@konnov konnov self-assigned this Jul 18, 2023
@konnov konnov added the repl Quint REPL (phase 5c) label Jul 18, 2023
Copy link
Contributor

@thpani thpani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -279,6 +279,7 @@ exit $exit_code


Use --verbosity=3 to show executions.
HOME/failingTestCounters.qnt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is HOME here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a placeholder for a path, so we do not have to use a real path in the test output

@konnov konnov merged commit be8bb62 into main Jul 18, 2023
15 checks passed
@konnov konnov deleted the igor/repl-verbosity branch July 18, 2023 14:48
@shonfeder shonfeder mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repl Quint REPL (phase 5c)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants