Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prisoners for examples dashboard #1049

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Fix prisoners for examples dashboard #1049

merged 2 commits into from
Jul 26, 2023

Conversation

thpani
Copy link
Contributor

@thpani thpani commented Jul 17, 2023

Fix prisoners example in the dashboard.

This one only needed a --main flag, and fixing the import statement (which is to be revised).

@thpani thpani added this to the Transpillation to ApalacheIR milestone Jul 17, 2023
@thpani thpani self-assigned this Jul 17, 2023
Copy link
Contributor

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bugarela bugarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need the export at all once some stuff I'm working on gets to main 😄 I actually have this same change in my local diff.

@bugarela
Copy link
Collaborator

I see there are failing integration tests. That's because the run command still requires the export. I have a fix for that locally, I'll see if I can easily extract it from my changes into a PR. If you can hold this until then, that'd be great.

@thpani thpani merged commit 4d66a86 into main Jul 26, 2023
15 checks passed
@thpani thpani deleted the th/fix-example-prisoners branch July 26, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants