Merge remote-tracking branch 'upstream/master' into feature/multiple_…

…schemas

HISTORY.md

@@ -1,3 +1,14 @@
+# 2.2.1
+  * June 19, 2019
+
+## Added
+  - #566: IGNORE_EMPTY_TENANTS environment variable to ignore empty tenants
+    warning. [Pysis868]
+
+## Fixed
+  - #586: Ignore `CREATE SCHEMA public` statement in pg dump [artemave]
+  - #549: Fix Postgres schema creation with dump SQL [ancorcruz]
+
 # 2.2.0
   * April 14, 2018
 

README.md

@@ -541,6 +541,31 @@ end
 
 See [apartment-sidekiq](https://github.com/influitive/apartment-sidekiq) or [apartment-activejob](https://github.com/influitive/apartment-activejob).
 
+## Callbacks
+
+You can execute callbacks when switching between tenants or creating a new one, Apartment provides the following callbacks:
+
+- before_create
+- after_create
+- before_switch
+- after_switch
+
+You can register a callback using [ActiveSupport::Callbacks](https://api.rubyonrails.org/classes/ActiveSupport/Callbacks.html) the following way:
+
+```ruby
+require 'apartment/adapters/abstract_adapter'
+
+module Apartment
+  module Adapters
+    class AbstractAdapter
+      set_callback :switch, :before do |object|
+        ...
+      end
+    end
+  end
+end
+```
+
 ## Contributing
 
 * In both `spec/dummy/config` and `spec/config`, you will see `database.yml.sample` files

lib/apartment/adapters/abstract_adapter.rb

@@ -120,6 +120,25 @@ def seed_data
       end
       alias_method :seed, :seed_data
 
+      #   Prepend the environment if configured and the environment isn't already there
+      #
+      #   @param {String} tenant Database name
+      #   @return {String} tenant name with Rails environment *optionally* prepended
+      #
+      def environmentify(tenant)
+        unless tenant.include?(Rails.env)
+          if Apartment.prepend_environment
+            "#{Rails.env}_#{tenant}"
+          elsif Apartment.append_environment
+            "#{tenant}_#{Rails.env}"
+          else
+            tenant
+          end
+        else
+          tenant
+        end
+      end
+
     protected
 
       def process_excluded_model(excluded_model)
@@ -163,25 +182,6 @@ def connect_to_new(tenant)
         raise_connect_error!(tenant, exception)
       end
 
-      #   Prepend the environment if configured and the environment isn't already there
-      #
-      #   @param {String} tenant Database name
-      #   @return {String} tenant name with Rails environment *optionally* prepended
-      #
-      def environmentify(tenant)
-        unless tenant.include?(Rails.env)
-          if Apartment.prepend_environment
-            "#{Rails.env}_#{tenant}"
-          elsif Apartment.append_environment
-            "#{tenant}_#{Rails.env}"
-          else
-            tenant
-          end
-        else
-          tenant
-        end
-      end
-
       #   Import the database schema
       #
       def import_database_schema

lib/apartment/adapters/postgresql_adapter.rb

@@ -114,6 +114,9 @@ class PostgresqlSchemaFromSqlAdapter < PostgresqlSchemaAdapter
         /SET lock_timeout/i,                          # new in postgresql 9.3
         /SET row_security/i,                          # new in postgresql 9.5
         /SET idle_in_transaction_session_timeout/i,   # new in postgresql 9.6
+        /CREATE SCHEMA public/i,
+        /COMMENT ON SCHEMA public/i,
+
       ]
 
       def import_database_schema

lib/apartment/tenant.rb

@@ -8,7 +8,7 @@ module Tenant
     extend self
     extend Forwardable
 
-    def_delegators :adapter, :create, :drop, :switch, :switch!, :current, :each, :reset, :set_callback, :seed, :current_tenant, :default_tenant
+    def_delegators :adapter, :create, :drop, :switch, :switch!, :current, :each, :reset, :set_callback, :seed, :current_tenant, :default_tenant, :environmentify
 
     attr_writer :config
 

lib/apartment/version.rb

@@ -1,3 +1,3 @@
 module Apartment
-  VERSION = "2.2.0"
+  VERSION = "2.2.1"
 end

lib/tasks/apartment.rake

@@ -130,7 +130,7 @@ apartment_namespace = namespace :apartment do
   end
 
   def warn_if_tenants_empty
-    if tenants.empty?
+    if tenants.empty? && ENV['IGNORE_EMPTY_TENANTS'] != "true"
       puts <<-WARNING
         [WARNING] - The list of tenants to migrate appears to be empty. This could mean a few things: